Conversation
dotnet-policy-service
bot
added
the
community-contribution
|
This is a prerequisite for using System.Net.Security on illumos. |
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @dotnet/area-system-security |
There was a problem hiding this comment.
Pull request overview
Updates native X509 store enumeration to avoid relying on sizeof(dirent.d_name) (which is not usable on illumos) when allocating buffers and handling certificate file names.
Changes:
- Compute the temporary path buffer size using
NAME_MAX/MAXNAMLEN(with a fallback) instead ofsizeof(d_name). - Add a guard to skip
.pfxentries whose names won’t fit in the remaining buffer space. - Switch filename length computation from
strnlen(..., sizeof(d_name))tostrlen(...).
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Can anyone help me interpret the CI build analysis? |
The "Build Analysis" is green which is the important one. Outerloop lanes tend to have a number of failures because they are flaky tests. The innerloop build is green, barring some already known failures. All that to say, "CI looks good for this PR". |
Can't use sizof(d->d_name) Use NAME_MAX instead
|
squashed. |
|
The failing check seems to have nothing to do with this change. |
Yeah, that's what the Build Analysis conclusion was, too. |
We do squash-merges, so it isn't necessary to do a squash before the merge. It actually just slowed things down, since I had to wait for the CI legs to all finish again. 😉 |
Can't use sizof(d->d_name)
Use NAME_MAX or MAXNAMLEN
Without this, the code running on illumos reads only 1 character of the file names in the certificates store and cannot find any certificates.